Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Our implementation of embedded_io::Write is wrong #840

Closed
1 of 2 tasks
thejpster opened this issue Aug 22, 2024 · 2 comments · Fixed by #895
Closed
1 of 2 tasks

Our implementation of embedded_io::Write is wrong #840

thejpster opened this issue Aug 22, 2024 · 2 comments · Fixed by #895

Comments

@thejpster
Copy link
Member

thejpster commented Aug 22, 2024 •
edited
Loading

See #837 (comment)
@thejpster thejpster mentioned this issue Aug 22, 2024
Merged
@jannic
Copy link
Member

jannic commented Aug 22, 2024

Oh no: Even for rp2040, there are two implementations of embedded_io::Write, one in for Writer and one for UartPeripheral.
In #838 I only fixed the first one.

jannic added a commit to jannic/rp-hal that referenced this issue Feb 4, 2025
@jannic
Fix implementations of embedded_io::Write for UartPeripheral
fff4f6c 
Fixes rp-rs#840
@jannic jannic mentioned this issue Feb 4, 2025
Merged
@jannic
Copy link
Member

jannic commented Feb 4, 2025

The change from #838 was already ported to rp2350 with #841.
The remaining issue in UartPeripheral will be fixed with #895, on both rp2040 and rp2350.

@jannic jannic closed this as completed in eea9ecf Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix implementations of embedded_io::Write for UartPeripheral jannic/rp-hal
2 participants
@jannic @thejpster