Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid REPO_ID for --disable-repo, --enable-repo, --repo and --setopt. #1082

Closed
kontura opened this issue Dec 11, 2023 · 1 comment · Fixed by #1064
Closed

Invalid REPO_ID for --disable-repo, --enable-repo, --repo and --setopt. #1082

kontura opened this issue Dec 11, 2023 · 1 comment · Fixed by #1064
Assignees
@kontura
Labels
Priority: LOW Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take

Comments

@kontura
Copy link
Contributor

kontura commented Dec 11, 2023

Options --setopt, --enable-repo, --disable-repo and --repo probably shoud't accept REPO_ID vaule that doesn't match any configured repository.

In dnf4 only --repo and --enablerepo throw an error on invalid REPO_ID. --disablerepo just shows a warning and --setopt doesn't show any problem.

Also in dnf4 --repo and --enablerepo options were affected by strict config option. This is now deprecated and the new --skip-broken and --skip-unavailable are no longer global like the repo options so they are not a great fit.
@kontura kontura self-assigned this Dec 11, 2023
@kontura kontura added Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take Priority: LOW labels Dec 11, 2023
@kontura kontura added this to DNF team Dec 11, 2023
@github-project-automation github-project-automation bot moved this to Backlog in DNF team Dec 11, 2023
@kontura kontura moved this from Backlog to In Progress in DNF team Dec 11, 2023
@kontura
Copy link
Contributor Author

kontura commented Dec 11, 2023

PR: #1064

@kontura kontura mentioned this issue Dec 11, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in DNF team Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kontura kontura

Labels
Priority: LOW Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take
Projects
DNF team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Throw an error on invalid repo input for setopt and *repo options kontura/dnf5
1 participant
@kontura