Add a %buildoptions section

[mkoncek]

Following on this feature: https://rpm-software-management.github.io/rpm/manual/buildsystem.html
We would like to adopt it for the Fedora Java stack. This means replacing a lot imperative code like:

%pom_remove_dep ...
rm .../Test.java
%mvn_build -- ...

with %BuildOption-s.

However in practice what it would mean for us is that it would now look like:

BuildOption: without_dep ...
BuildOption: without_test ...
BuildOption: with_mvn_args ...

And I say that this is hardly an improvement when it comes to readability.
I imagine there could be a .spec section %buildoptions where I could write line-separated options, like:

%buildoptions
without_dep ...
without_test ...
with_mvn_args ...

[pmatilai]

The examples make me wonder if there's some confusion with %bcond involved.

Anyway, it's an interesting suggestion. A problem with the section syntax is that BuildOptions can exist for multiple sections, so you'd need potentially multiple sections too, something like %buildoption install and %buildoption conf (the latter being alias to bare %buildoption as with BuildOption)

And yes, BuildOption is not exactly pretty (the spec syntax doesn't easily lend itself to aesthetics 😆 ). It's all about declarativity, and the benefits coming from that.

[mkoncek]

I believe our prototype build system simply reads all the BuildOptions and generates %prep, %build, %install steps from the context, not from passed flags, so in our case we do not need to distinguish between them.

[pmatilai]

Um. BuildOption's are something only rpmbuild has access to, and passes them to the specified section as appropriate.