From 9e92b673c963247e97f66a3183bc2899988f5fb6 Mon Sep 17 00:00:00 2001 From: Satyajit Sahoo Date: Fri, 22 Apr 2022 20:08:43 +0200 Subject: [PATCH] chore: update pull request template --- .github/PULL_REQUEST_TEMPLATE.md | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 74790f74a9..9c7555c5e4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,17 +1,13 @@ -Please provide enough information so that others can review your pull request: +Please provide enough information so that others can review your pull request. **Motivation** Explain the **motivation** for making this change. What existing problem does the pull request solve? -**Test plan** - -Demonstrate the code is solid. Example: the exact commands you ran and their output, screenshots / videos if the pull request changes UI. +If this pull request addresses an existing issue, link to the issue. If an issue is not present, describe the issue here. -Make sure you test on both platforms if your change affects both platforms. - -The code must pass tests. +**Test plan** -**Code formatting** +Describe the **steps to test this change** so that a reviewer can verify it. Provide screenshots or videos if the change affects UI. -Look around. Match the style of the rest of the codebase. Run `yarn lint --fix` before committing. +The change must pass lint, typescript and tests.