Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that SDO Block Upload is not implemented #12

Open
follower opened this issue Apr 22, 2019 · 1 comment
Open

Document that SDO Block Upload is not implemented #12

follower opened this issue Apr 22, 2019 · 1 comment

Comments

@follower
Copy link

While a function named canopen_sdo_upload_block() exists, it has no implementation:

int
canopen_sdo_upload_block(int sock, uint8_t node, uint16_t index, uint8_t subindex,
uint8_t *data, uint32_t data_len)
{
return -1;
}

A Python wrapper function does exist but uses the unimplemented C function:

def SDOUploadBlock(self, node, index, subindex, size):
"""
Block SDO upload.
"""
data = create_string_buffer(int(size))
ret = libcanopen.canopen_sdo_upload_block(self.sock, c_uint8(node), c_uint16(index), c_uint8(subindex), data, c_uint16(size));
if ret != 0:
raise Exception("CANopen Block SDO upload error")
return binascii.hexlify(data)

The Python wrapper function used to mention that the function was unimplemented but the note was removed here.

@follower
Copy link
Author

Also here:

// XXX: incomplete
//canopen_frame_set_sdo_upload(&canopen_frame, node, index, subindex);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant