Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 bug: in rare cases, we might deploy an older commit than intended #631

Open
larwaa opened this issue Apr 7, 2022 · 0 comments
Open

🐞 bug: in rare cases, we might deploy an older commit than intended #631

larwaa opened this issue Apr 7, 2022 · 0 comments
Labels
bug Something isn't working CI/CD Relates to CI/CD

Comments

@larwaa
Copy link
Member

larwaa commented Apr 7, 2022

Describe the bug

We have restrictions on concurrency for our deploy job, but if an older PR finishes the rest of the pipeline after a later PR, then that PR will be deployed even though it should've been cancelled.

To Reproduce

Steps to reproduce the behavior:

  1. Merge a PR that finishes it's tests slowly
  2. Merge a PR that finishes it's tests quickly
  3. Cross your fingers that the timing matches up for this issue to occur
  4. See that the older commit is deployed after the latest commit

Expected behavior

A later commit should always be deployed after an older commit
@larwaa larwaa added bug Something isn't working CI/CD Relates to CI/CD labels Apr 7, 2022
@larwaa larwaa added this to Roadmap Apr 7, 2022
@larwaa larwaa moved this to Todo in Roadmap Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CI/CD Relates to CI/CD
Projects
Roadmap
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@larwaa