Use dynamic modules to allow correct `call` inheritance #20

rewritten · 2020-09-03T16:29:57Z

This should close #19

With this change, the ancestors of a subclass of a service are:

puts my_service_instance.class.ancestors
# SubClass::InjectableCallFacade
# SubClass
# Injectable::InstanceMethods
# SuperClass::InjectableCallFacade
# SuperClass
# Injectable
# Object
# Kernel
# BasicObject

Each concrete class over Injectable gets a dynamically generated module, with a :call implementation that

if the concrete class is the actual class of an object, takes the arguments as expected, and then call super with no arguments.
otherwise, it will assume that another facade has already run, so it will just call super with no arguments.

This way we have an alternating chain of methods (one in the facade and one in the concrete class) that call each other.

The dynamically generated module does not need to be assigned to a constant, but it helps when reading traces.

codeclimate · 2020-09-03T16:30:28Z

lib/injectable/call_facade.rb

@@ -0,0 +1,26 @@
+module Injectable
+  module CallFacade
+    def self.[](klass)


Complex method Injectable::CallFacade::[] (23.6)

codeclimate · 2020-09-03T16:30:29Z

lib/injectable/call_facade.rb

+        define_method :call do |args = {}|
+          if self.instance_of?(klass)
+            check_call_definition!
+            check_missing_arguments!(self.class.required_call_arguments, args)


Injectable::CallFacade#self.[] calls 'self.class' 2 times

codeclimate · 2020-09-03T16:30:29Z

lib/injectable/call_facade.rb

@@ -0,0 +1,26 @@
+module Injectable
+  module CallFacade


Injectable::CallFacade has no descriptive comment

codeclimate · 2020-09-03T16:30:29Z

lib/injectable/call_facade.rb

@@ -0,0 +1,26 @@
+module Injectable
+  module CallFacade
+    def self.[](klass)


Injectable::CallFacade#self.[] has approx 8 statements

codeclimate · 2020-09-03T16:30:29Z

lib/injectable/call_facade.rb

+module Injectable
+  module CallFacade
+    def self.[](klass)
+      m = Module.new do


Injectable::CallFacade#self.[] has the variable name 'm'

codeclimate · 2020-09-03T16:30:30Z

lib/injectable/call_facade.rb

+    def self.[](klass)
+      m = Module.new do
+        # Entry point of the service.
+        # Arguments for this method should be declared explicitly with '.argument'


Line is too long. [82/80]

codeclimate · 2020-09-03T16:30:30Z

lib/injectable/call_facade.rb

@@ -0,0 +1,26 @@
+module Injectable
+  module CallFacade
+    def self.[](klass)


Method has too many lines. [14/10]

codeclimate · 2020-09-03T16:30:30Z

lib/injectable/call_facade.rb

@@ -0,0 +1,26 @@
+module Injectable
+  module CallFacade


Missing top-level module documentation comment.

codeclimate · 2020-09-03T16:30:30Z

lib/injectable/call_facade.rb

+        # Arguments for this method should be declared explicitly with '.argument'
+        # and declare this method without arguments
+        define_method :call do |args = {}|
+          if self.instance_of?(klass)


Redundant self detected.

codeclimate · 2020-09-03T16:30:31Z

lib/injectable/instance_methods.rb

    private

    def check_call_definition!
      return if (self.class.ancestors - [Injectable::InstanceMethods]).any? do |ancestor|
-        ancestor.instance_methods(false).include?(:call)
+        ancestor.instance_methods(false).include?(:call) && !ancestor.respond_to?(:facade?)


Line is too long. [91/80]

codeclimate · 2020-09-03T16:30:32Z

Code Climate has analyzed commit a7ae61e and detected 12 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	8
Style	4

View more on Code Climate.

rewritten · 2020-09-03T16:31:49Z

lib/injectable/call_facade.rb

+          super()
+        end
+
+        def self.facade?


Here we can use different ways to recognize a module as a facade. It's anyways important, otherwise check_call_definition! will give false positives.

Use dynamic modules to allow correct call inheritance

a7ae61e

codeclimate bot reviewed Sep 3, 2020

View reviewed changes

rewritten commented Sep 3, 2020

View reviewed changes

rewritten closed this Feb 9, 2022

rewritten deleted the inheritance branch February 9, 2022 14:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use dynamic modules to allow correct `call` inheritance #20

Use dynamic modules to allow correct `call` inheritance #20

rewritten commented Sep 3, 2020

codeclimate bot Sep 3, 2020

codeclimate bot Sep 3, 2020

codeclimate bot Sep 3, 2020

codeclimate bot Sep 3, 2020

codeclimate bot Sep 3, 2020

codeclimate bot Sep 3, 2020

codeclimate bot Sep 3, 2020

codeclimate bot Sep 3, 2020

codeclimate bot Sep 3, 2020

codeclimate bot Sep 3, 2020

codeclimate bot commented Sep 3, 2020

rewritten Sep 3, 2020

Use dynamic modules to allow correct call inheritance #20

Use dynamic modules to allow correct call inheritance #20

Conversation

rewritten commented Sep 3, 2020

codeclimate bot Sep 3, 2020

Choose a reason for hiding this comment

codeclimate bot Sep 3, 2020

Choose a reason for hiding this comment

codeclimate bot Sep 3, 2020

Choose a reason for hiding this comment

codeclimate bot Sep 3, 2020

Choose a reason for hiding this comment

codeclimate bot Sep 3, 2020

Choose a reason for hiding this comment

codeclimate bot Sep 3, 2020

Choose a reason for hiding this comment

codeclimate bot Sep 3, 2020

Choose a reason for hiding this comment

codeclimate bot Sep 3, 2020

Choose a reason for hiding this comment

codeclimate bot Sep 3, 2020

Choose a reason for hiding this comment

codeclimate bot Sep 3, 2020

Choose a reason for hiding this comment

codeclimate bot commented Sep 3, 2020

rewritten Sep 3, 2020

Choose a reason for hiding this comment

Use dynamic modules to allow correct `call` inheritance #20

Use dynamic modules to allow correct `call` inheritance #20