Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various type signature updates for Rails #735

Closed
wants to merge 16 commits into from

Conversation

hjwylde
Copy link
Contributor

@hjwylde hjwylde commented Dec 5, 2024

Hi! I have been working on improving the warnings in RubyMine based on type signatures to work better, and there were a number of false warnings I found. The majority of the warnings are related to block specifications being too rigid when they should be marked as optional. I've improved the type signatures where possible, but the majority are just tiny changes to ensure that there are no false positive warnings from these signatures.

Any signatures touched were additionally moved from the generated file to the manual file (as I saw that done in other pull requests).

Copy link

github-actions bot commented Dec 5, 2024

@hjwylde Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

actionpack

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@ksss, @tk0miya, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.


actionview

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@ksss, @ydah, @tk0miya, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.


activemodel

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, @tk0miya, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.


activerecord

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, @Little-Rubyist, @tk0miya, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.


activesupport

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, @ydah, @tk0miya, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.


railties

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@ksss, @tk0miya, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

@hjwylde hjwylde force-pushed the hjwylde/gem_collection_updates branch from faf5ea0 to 08adb5d Compare December 5, 2024 23:56
@ksss
Copy link
Collaborator

ksss commented Dec 6, 2024

@hjwylde Thank you for contributing.
But sorry, there are too many changes, and I feel it's difficult for me to review them.

@hjwylde
Copy link
Contributor Author

hjwylde commented Dec 6, 2024

@hjwylde Thank you for contributing. But sorry, there are too many changes, and I feel it's difficult for me to review them.

Would it be enough to split this into different pull requests per gem?

@hjwylde
Copy link
Contributor Author

hjwylde commented Dec 6, 2024

I will close this review and create a separate one for each gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants