-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various type signature updates for Rails #735
Conversation
…ures to use an optional block
@hjwylde Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
… have key/value arguments
…ptions parameters
faf5ea0
to
08adb5d
Compare
@hjwylde Thank you for contributing. |
Would it be enough to split this into different pull requests per gem? |
I will close this review and create a separate one for each gem. |
Hi! I have been working on improving the warnings in RubyMine based on type signatures to work better, and there were a number of false warnings I found. The majority of the warnings are related to block specifications being too rigid when they should be marked as optional. I've improved the type signatures where possible, but the majority are just tiny changes to ensure that there are no false positive warnings from these signatures.
Any signatures touched were additionally moved from the generated file to the manual file (as I saw that done in other pull requests).