actionview: signature updates #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hjwylde Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
tk0miya
reviewed
Dec 10, 2024
| # Hello world! | ||
| # <% end -%> | ||
| # # => <div class="strong">Hello world!</div> | ||
| def content_tag: (untyped name, ?untyped? content_or_options_with_block, ?untyped? options, ?bool escape) ?{ () -> untyped } -> untyped |
There was a problem hiding this comment.
| # | ||
| # If no options hash is passed or :update specified, the default is to render a partial and use the second parameter | ||
| # as the locals hash. | ||
| def render: (?::Hash[untyped, untyped] options, ?::Hash[untyped, untyped] locals) ?{ () -> untyped } -> untyped |
There was a problem hiding this comment.
| # raw('Accept <a href="/terms">Terms</a>.') | ||
| # end | ||
| # # => <label for="post_terms">Accept <a href="/terms">Terms</a>.</label> | ||
| def label: (untyped object_name, untyped method, ?untyped? content_or_options, ?untyped? options) ?{ () -> untyped } -> untyped |
| # raw('Accept <a href="/terms">Terms</a>.') | ||
| # end | ||
| # # => <label for="post_terms">Accept <a href="/terms">Terms</a>.</label> | ||
| def label: (untyped method, ?untyped? text, ?::Hash[untyped, untyped] options) ?{ () -> untyped } -> untyped |
| # # <strong>Ask me!</strong> | ||
| # # </button> | ||
| # | ||
| def button: (?untyped? value, ?::Hash[untyped, untyped] options) ?{ () -> untyped } -> untyped |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #735 to be smaller. Type signature updates for invalid signatures in actionview, due to blocks being marked as required, but they should be optional.