Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activerecord: Add types for load_async #767

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

Copy link

@dak2 Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activerecord

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, @Little-Rubyist, @tk0miya, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

Copy link

Thanks for your review, @ksss!

@dak2, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@dak2
Copy link
Contributor Author

dak2 commented Jan 16, 2025

/merge

Copy link

/merge command failed.

This PR is not approved yet by the reviewers. Please get approval from the reviewers.

See the Actions tab for detail.

@dak2
Copy link
Contributor Author

dak2 commented Jan 16, 2025

@ksss

Could you re-review this pr ?

Sorry, I accidentally hit the button to merge main branch.
So the /merge action is now disabled.

@dak2 dak2 requested a review from ksss January 16, 2025 12:19
Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

Copy link

Thanks for your review, @ksss!

@dak2, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@dak2
Copy link
Contributor Author

dak2 commented Jan 16, 2025

/merge

@github-actions github-actions bot merged commit 8ea5c19 into ruby:main Jan 16, 2025
6 checks passed
@dak2 dak2 deleted the activerecord/load_async branch January 16, 2025 12:45
@dak2
Copy link
Contributor Author

dak2 commented Jan 16, 2025

@ksss

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants