-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dead link in the README.md #804
Comments
ruby-doc.org is NOT the official documentation website, nor is So unless there's also a deadlink on the official website, there's nothing we can fix here. |
Hi @st0012 thank you for the comment. https://docs.ruby-lang.org/en/master/Readline.html exists (good news) but it looks less informative than https://ruby-doc.org/3.2.6/exts/readline/Readline.html (bad news) If you agree with updating the link in README.md to https://docs.ruby-lang.org/en/master/Readline.html I am happy to open a pull request. |
The page at https://docs.ruby-lang.org/en/master/Readline.html is displaying Reline documentation instead of Readline documentation. We should fix RDoc or RDoc generation process. |
Does it make sense to remove the link from the README.md like below? diff --git a/before.md b/after.md
index a28588e..02a4e0b 100644
--- a/before.md
+++ b/after.md
@@ -2,4 +2,4 @@
It's compatible with the readline standard library.
-See [the document of readline stdlib](https://ruby-doc.org/stdlib/exts/readline/Readline.html) or [bin/example](https://github.com/ruby/reline/blob/master/bin/example).
+See [bin/example](https://github.com/ruby/reline/blob/master/bin/example). |
Ah yes, we should fix it. Sorry that I missed that part.
I believe it comes from: https://github.com/ruby/ruby/blob/master/lib/readline.rb#L6. If you remove this part Since |
Ideally, I think reline should have its own documentation for all of its features and stop referencing to readline's docs. |
Hi,
I found that this link https://ruby-doc.org/stdlib/exts/readline/Readline.html in the README.md is 404 Not Found.
/stdlib/exts/readline/Readline.html
does not exist in 3.4.1 doc. There are a few pages related to Readline but they appear blank.3.3.6 has the same issue.
3.2.6 does not have the issue. https://ruby-doc.org/3.2.6/exts/readline/Readline.html exists.
I am not sure what approach is the best:
so just reporting it to the Reline maintainers.
The text was updated successfully, but these errors were encountered: