-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User-specified build flags #39
Comments
Now we have the -F option. Any other requirements here? |
The intention, as far as I remember, was to take them from the env when rumpmake is run. That might just be handled with the buildconfig branch. However, -F doesn't allow separate hypervisor and kernel flags. |
We could add a -h option to just build hypervisor and not kernel perhaps? |
I don't think it's quite that simple ;-) The I/O related hypercalls are private to components and generally bundled with them, so some careful planning is required. I'm not quite happy with how virtif users deal with it, though it's the best way that we currently have. |
OK, but that does leave this issue a bit vague ;-) That reminds me I had another idea about virtif that I was going to experiment with too. |
I think that we need to come up with a list of scenarios that should work, and then modify the code based on that list. Otherwise we'll just keep modifying the code back and forth. |
OK, well I don't know that I can think of any scenarios where it would be necessary... |
One easy example: hypercalls should use headers from -I/foo instead of /usr/include |
Make setting BUILDRUMP_C{,PP}FLAGS etc. in the env work as expected: extra flags passed to the compiler.
We probably need two sets of variables: one set hypervisor components and one set for kernel components.
The text was updated successfully, but these errors were encountered: