Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README is stale #33

Open
tcharding opened this issue Jan 21, 2025 · 3 comments
Open

README is stale #33

tcharding opened this issue Jan 21, 2025 · 3 comments

Comments

@tcharding
Copy link
Member

tcharding commented Jan 21, 2025 •
edited
Loading

See https://crates.io/crates/ordered

  • Wrong MSRV
  • Deprecated functions still mentioned (e.g. as_inner)
@tcharding tcharding changed the title README has wrong MSRV README is stale Jan 21, 2025
@apoelstra
Copy link
Member

Do we actually need this trait anymore? It seems like it exists only for the locktime types, which can be manually ordered by users who want them. (And manually ordering them is barely harder, if not easier, than using this trait.)

@tcharding
Copy link
Member Author

Interesting observation, with the passing time since we wrote this it does seem like no other place in rust-bitcoin needs this trait.

I'd be happy to 1.0 this crate, state in the readme that this is a very niche thing and possibly not even that useful then remove it from rust-bitcoin.

@apoelstra
Copy link
Member

Yeah, I do think we can 1.0 it. It's so simple and small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apoelstra @tcharding