Explicitly build proc macro test with panic=unwind #135225
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
bjorn3
reviewed
Jan 8, 2025
jieyouxu
added
S-waiting-on-author
erickt
force-pushed
the
fix-test
branch
2 times, most recently
from
3dc1c38 to
22ec81a
Compare
|
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
|
Thanks for the suggestions! That's much better than manually specifying |
This comment has been minimized.
This comment has been minimized.
Fuchsia explicitly builds rust and all rust targets with `-C panic=abort` to minimize code generation size. However, when compiling a proc-macro with this setting it can cause a warning to be emitted, which breaks `tests/ui/invalid-compile-flags/crate-type-flag.rs`. This hasn't been a problem in the past for us since we compile our proc macros on host, rather than inside Fuchsia. This attempts to fix the issue by explicitly requiring that we're using the unwinder when compiling this test to avoid the warning being emitted. Fixes rust-lang#135223
|
Thanks! |
bors
added
S-waiting-on-bors
|
FTR, this test actually wants a proper supports-crate-type directive i.e. #132309, I had a bunch of these needs-* directive as a poor man's emulation to that effect. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 9, 2025
Explicitly build proc macro test with panic=unwind Fuchsia explicitly builds rust and all rust targets with `-C panic=abort` to minimize code generation size. However, when compiling a proc-macro with this setting it can cause a warning to be emitted, which breaks `tests/ui/invalid-compile-flags/crate-type-flag.rs`. This hasn't been a problem in the past for us since we compile our proc macros on host, rather than inside Fuchsia. This attempts to fix the issue by explicitly requiring that we're using the unwinder when compiling this test to avoid the warning being emitted. Fixes rust-lang#135223
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jan 9, 2025
Explicitly build proc macro test with panic=unwind Fuchsia explicitly builds rust and all rust targets with `-C panic=abort` to minimize code generation size. However, when compiling a proc-macro with this setting it can cause a warning to be emitted, which breaks `tests/ui/invalid-compile-flags/crate-type-flag.rs`. This hasn't been a problem in the past for us since we compile our proc macros on host, rather than inside Fuchsia. This attempts to fix the issue by explicitly requiring that we're using the unwinder when compiling this test to avoid the warning being emitted. Fixes rust-lang#135223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuchsia explicitly builds rust and all rust targets with
-C panic=abortto minimize code generation size. However, when compiling a proc-macro with this setting it can cause a warning to be emitted, which breakstests/ui/invalid-compile-flags/crate-type-flag.rs. This hasn't been a problem in the past for us since we compile our proc macros on host, rather than inside Fuchsia.This attempts to fix the issue by explicitly requiring that we're using the unwinder when compiling this test to avoid the warning being emitted.
Fixes #135223