Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the nu parameter used incorrectly, for svm regression? #317

Open
marcusbuffett opened this issue Oct 11, 2023 · 2 comments · May be fixed by #370
Open

Is the nu parameter used incorrectly, for svm regression? #317

marcusbuffett opened this issue Oct 11, 2023 · 2 comments · May be fixed by #370
Labels
bug Something isn't working

Comments

@marcusbuffett
Copy link

Was just browsing through the source, and this seemed weird, I could be totally off-base so feel free to just close, but in fit_nu, nu is the last param , but when it's called, nu is the second-to-last param, and c is the last param: https://github.com/rust-ml/linfa/blob/master/algorithms/linfa-svm/src/regression.rs#L144-L145
@YuhanLiin
Copy link
Collaborator

Not sure about this one. @bytesnake You wrote the SVM implementation right? Any ideas?

@relf
Copy link
Member

relf commented Jan 21, 2025

Thanks for reporting. Indeed comparing with the original libsvm implementation it seems there is a mixup between nu, c and eps parameters.

@relf relf added the bug Something isn't working label Jan 21, 2025
@relf relf linked a pull request Jan 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[linfa-svm] Fix SVR nu parameter passing and rework SVR parameterization API relf/linfa
3 participants
@relf @marcusbuffett @YuhanLiin