Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repository = "s3:..." doesn't work as expected #1045

Closed
simonsan opened this issue Feb 4, 2024 · 2 comments · Fixed by rustic-rs/rustic_core#200
Closed

repository = "s3:..." doesn't work as expected #1045

simonsan opened this issue Feb 4, 2024 · 2 comments · Fixed by rustic-rs/rustic_core#200
Labels
A-backends Area: Related to backends in `rustic-core` A-config Area: Related to the config file functionality and format A-ui-ux Area: Related to user interfaces and user experience C-bug Category: Something isn't working as expected

Comments

@simonsan
Copy link
Contributor

simonsan commented Feb 4, 2024

TL;DR: use repository = "opendal:s3" like specifed in https://github.com/rustic-rs/rustic/tree/main/config/services

As this works:

[repository]
repository = "opendal:s3"
password = "pass"

[repository.options]
root = "/"
bucket = "test-dal"
endpoint = "https://p7v1.ldn.idrivee2-40.com"
region = "gb-ldn"
access_key_id = "xxx"
secret_access_key = "xxx"

and this does not:

[repository]
repository = "s3:https://p7v1.ldn.idrivee2-40.com/test-dal"
password = "pass"

[repository.options]
access_key_id = "xxx"
secret_access_key = "xxx"
region = "gb-ldn"

It looks like s3 backend has some problem collecting all data from toml file. Both examples above contain all the same information.

Originally posted by @kapitainsky in #1044 (comment)

@github-actions github-actions bot added the S-triage Status: Waiting for a maintainer to triage this issue/PR label Feb 4, 2024
@simonsan
Copy link
Contributor Author

simonsan commented Feb 4, 2024

It looks like rustic internally sets endpoint=http://127.0.0.1:9000/ (with a trailing slash). This causes a request url like this http://127.0.0.1:9000//rustic/config.
If I set endpoint to that value manually I get the same error.
It seems like Minio does not like the //.

Originally posted by @l-austenfeld in #1044 (reply in thread)

@simonsan simonsan added C-bug Category: Something isn't working as expected A-backends Area: Related to backends in `rustic-core` A-ui-ux Area: Related to user interfaces and user experience A-config Area: Related to the config file functionality and format and removed S-triage Status: Waiting for a maintainer to triage this issue/PR labels Feb 4, 2024
@aawsome aawsome changed the title S3 backend options don't work as expected repository = "s3:..." doesn't work as expected Feb 5, 2024
@aawsome
Copy link
Member

aawsome commented Mar 13, 2024

We'll remove the possibility to use "s3:.." in the next release. opendal is the preferred way and works for all users.

github-merge-queue bot pushed a commit to rustic-rs/rustic_core that referenced this issue Mar 13, 2024
`s3` and `sftp` can be used with `opendal`. Users didn't complain that
using `opendal` poses any problems or inconveniences.
The current wrapper also have some unfixed bugs, so we remove them.

closes rustic-rs/rustic#1045
closes rustic-rs/rustic#1047

---------

Signed-off-by: simonsan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backends Area: Related to backends in `rustic-core` A-config Area: Related to the config file functionality and format A-ui-ux Area: Related to user interfaces and user experience C-bug Category: Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants