From f69c7976f4a56b526ec9b0e71ade95b4ef722085 Mon Sep 17 00:00:00 2001 From: shguanWHU Date: Fri, 29 Nov 2024 19:29:48 +0000 Subject: [PATCH 1/2] update the standard from 14 to 17 to avoid compile error --- CMakeLists.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index a6aec091..e0a5e11f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,6 +1,7 @@ cmake_minimum_required(VERSION 3.0) project(torchscatter) -set(CMAKE_CXX_STANDARD 14) +set(CMAKE_CXX_STANDARD 17) +set(CMAKE_CXX_STANDARD_REQUIRED) set(TORCHSCATTER_VERSION 2.1.2) option(WITH_CUDA "Enable CUDA support" OFF) From f8f00fa5b12b25a26d636d810164af6756aec5de Mon Sep 17 00:00:00 2001 From: shguanWHU Date: Tue, 14 Jan 2025 22:43:07 +0000 Subject: [PATCH 2/2] set require cxx 17 on, or there is error: 'optional': is not a member of 'std' --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index e0a5e11f..e011caf6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,7 +1,7 @@ cmake_minimum_required(VERSION 3.0) project(torchscatter) set(CMAKE_CXX_STANDARD 17) -set(CMAKE_CXX_STANDARD_REQUIRED) +set(CMAKE_CXX_STANDARD_REQUIRED ON) set(TORCHSCATTER_VERSION 2.1.2) option(WITH_CUDA "Enable CUDA support" OFF)