Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in code #2

Open
ponytaill opened this issue Nov 23, 2024 · 3 comments
Open

Bug in code #2

ponytaill opened this issue Nov 23, 2024 · 3 comments

Comments

@ponytaill
Copy link

Hi, thanks for your work. I am very interested in your research. But when I run your code, I get a lot of errors.
Like File "/home/SimLayerKV/LongBench/pred.py", line 317, in
if args.window_size == 512:
AttributeError: 'Namespace' object has no attribute 'window_size'
And there seems no write_model_name in the code. Could you check your code? I believe the code doesn't seem to run directly, a lot of configuration is missing.

@jadeCurl
Copy link
Collaborator

Hi,

Thanks for pointing out! I'll update the code shortly.

@xlim1996
Copy link

xlim1996 commented Jan 8, 2025

Hi,

Could you please resolve the bug in your code? Besides fixing the previous issues mentioned by @ponyta, I found that there are still a few bugs in your code or environment, such as: ValueError: The followingmodel_kwargsare not used by the model: ['threshold'] (note: typos in the generate arguments will also show up in this list)

@jadeCurl
Copy link
Collaborator

jadeCurl commented Jan 8, 2025

Hi, we are currently orgnizing our V2 version with big modifications in the identification algorithm, and will release the new code within a month. If you want to get a bug-free version asap, please check the implementation of SimLayerKV in KVPress .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants