-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] Make PhoneMemory
-folder user-configurable
#15
Labels
enhancement
Enhances something
feature request
feature requests, suggestions, ideas etc.
help wanted
Extra attention is needed
Comments
Olf0
pushed a commit
that referenced
this issue
Nov 5, 2023
Closes #15 This should return the current user's home directory instead of hard-coding it. Documentation reference: https://doc.qt.io/qt-5/qstandardpaths.html Alternatively, [`QDir::homePath](https://doc.qt.io/qt-5/qdir.html#homePath) can be used. (not actually tested)
Likely "the best solution would be to use the home dir as default and let users change it if desired", as @simonschmeisser denoted. |
What remains, is that it is not nice that one cannot set the default path (but one of multiple, manually user-selectable "default locations") in the GUI: not really a big issue. P.S.: For a suggestion for a more elegant solution, see issue #67. |
Olf0
changed the title
"Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible
[~~Bug~~ Suggestion] "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible
Feb 7, 2024
Olf0
changed the title
[~~Bug~~ Suggestion] "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible
[Suggestion] "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible
Feb 7, 2024
Olf0
changed the title
[Suggestion] "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible
[Was bug, now is suggestion] "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible
Feb 7, 2024
Olf0
changed the title
[Was bug, now is suggestion] "Hardcoded" PhoneMemory-folder makes /home/nemo practically inaccessible
[Was bug, now is suggestion] "Hardcoded" PhoneMemory-folder makes Feb 7, 2024
/home/nemo
practically inaccessible
Olf0
changed the title
[Was bug, now is suggestion] "Hardcoded" PhoneMemory-folder makes
[Suggestion] Make Feb 7, 2024
/home/nemo
practically inaccessiblePhoneMemory
-folder user-configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Enhances something
feature request
feature requests, suggestions, ideas etc.
help wanted
Extra attention is needed
Original title:
[Bug] "Hardcoded"
PhoneMemory
-folder makes/home/nemo
practically inaccessible@llewelld I was surprised to see, that I cannot simply select
/home/nemo
as my default folder in FileCase ≥ 0.2.1, but was relieved for a second when I found your commit 7369833 with its headline and description:Remove hardcoded references to
/home/nemo
Moves the definition of the home folder into the settings file and defaults to
/home/defaultuser
.But then I discovered, that:
/home/defaultuser
, not/home/default
as denoted in the headline of commit 7369833./home/defaultuser
) for a new setting (home
) breaks extant installations of FileCase, which were using/home/nemo
, when updating them to any version ≥ 0.2.1.IMO performing this change in such a manner is a bit "evil", because it will leave many helplessly stranded. It took me more than 15 minutes of research and testing to comprehend how to utilise this correctly.
My criticism ultimately is, that this commit is only a half-step towards implementing a GUI option in FileCase's settings to make this option accessible for an average user.
My suggestion is to offer
/home/nemo
and/home/defaultuser
as predefined values, but to allow for inputting any path.Hence I suggested via PR #14 (merged) to alter settings option "home" to "PhoneMemoryFolder", because that is what it is called at the GUI, is more self-explanatory and is aligned with extant option names (e.g., in "CamelCase").
But this still leaves the ToDo open to implement a GUI option for setting this in FileCase's settings page.
TL;DR (documenting the current workaround for others)
~/.config/cepiperez/fileboxplus.conf
in the[General]
section since FileCase 0.2.1, e.g.,home=/home/nemo
For releases after PR config.cpp: Alter option "home"→"PhoneMemoryFolder" #14 (i.e., FileCase > 0.4.0) this is, e.g.,
PhoneMemoryFolder=/home/nemo
/home/nemo
) and there into.config/cepiperez
fileboxplus.conf
, select "Rename" in the pulley menu and append the extension.txt
fileboxplus.conf.txt
, select "Edit" in the pulley menu and add aforementioned line in the[General]
section.fileboxplus.conf.txt
again, select "Rename" in the pulley menu and remove the extension.txt
, so that the file is calledfileboxplus.conf
again.The text was updated successfully, but these errors were encountered: