Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ToDo] Deduplicate icons #75

Open
Olf0 opened this issue Feb 26, 2024 · 0 comments
Open

[ToDo] Deduplicate icons #75

Olf0 opened this issue Feb 26, 2024 · 0 comments

Comments

@Olf0
Copy link
Collaborator

Olf0 commented Feb 26, 2024

rpmlint as employed by the Sailfish-OBS criticises (just warnings, no errors):

RPMLINT report:
===============
filecase.i486: W: files-duplicate /usr/share/filecase/icons/filecase.png /usr/share/icons/hicolor/86x86/apps/filecase.png

filecase.i486: W: files-duplicate /usr/share/filecase/icons/exec.png /usr/share/filecase/icons/setting.png

filecase.i486: W: files-duplicate /usr/share/filecase/icons/document.png /usr/share/filecase/icons/txt.png

filecase.i486: W: files-duplicate /usr/share/filecase/icons/skydrive.png /usr/share/filecase/icons/sky.png

I assume the first one may be unavoidable and likely produced by qmake, which is instructed to copy the source directory icons to $buildroot/usr/share/filecase/, but also (where?) to copy the app icon to /usr/share/icons/hicolor/86x86/apps/.
The only thing one may check in the source tree is, if /usr/share/filecase/icons/filecase.png is directly used; still I have no idea where to put it in the first place, if it only needs to be copied to /usr/share/icons/hicolor/86x86/apps/.

The latter three are "real duplicates" and may be substituted by symbolic links, but supposedly the real resolution is to only use one of the two names throughout FileCase's source tree.
Although I am not sure, if one of each in the pairs exec.png / setting.png and document.png / txt.png is meant as a placeholder for a better suited icon (i.e. better depicting what it stands for): Only to look up the places at which these icon pairs are used will tell for sure.

@Olf0 Olf0 changed the title Duplicate icons [ToDo] Duplicate icons Feb 26, 2024
@Olf0 Olf0 changed the title [ToDo] Duplicate icons [ToDo] Deduplicate icons Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant