Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Trying to revive the functionality of extras/Lockscreen.qml #102

Open
Olf0 opened this issue Jun 16, 2024 · 0 comments
Open
Labels
feature request feature requests, suggestions, ideas etc.

Comments

@Olf0
Copy link
Contributor

Olf0 commented Jun 16, 2024

extras/Lockscreen.qml was identified as historic, unused code (a few more details in the last paragraph here).

The obvious solution IMO is to transform extras/Lockscreen.qml into a Patch for Patchmanager.

Notes

P.S.: Aside of technical aspects this file also looks problematic under copyright / licensing aspects. This is what Patchmanager for SailfishOS (and its original foundation: AUSMT for WebOS) was invented for: to alter proprietary script files.

@Olf0 Olf0 added the feature request feature requests, suggestions, ideas etc. label Jun 16, 2024
Olf0 added a commit that referenced this issue Jun 16, 2024
Denote that this file currently comprises dead, problematic code; for details see issue #102.
Olf0 added a commit that referenced this issue Jul 4, 2024
Olf0 added a commit that referenced this issue Nov 29, 2024
* Translate translations/flowplayer.ts in sv (#90)

100% translated source file: 'translations/flowplayer.ts'
on 'sv'.

Co-authored-by: @eson57 via transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

* Translate translations/flowplayer.ts in de (#91)

100% translated source file: 'translations/flowplayer.ts'
on 'de'.

Co-authored-by: @Olf0 via transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

* Translate translations/flowplayer.ts in et (#92)

100% translated source file: 'translations/flowplayer.ts'
on 'et'.

Co-authored-by: @Olf0 via transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

* [Tx: translations/flowplayer.ts] Add Finnish translation (fi) #94

100% translated source file: 'translations/flowplayer.ts'
on 'fi'.

Co-authored-by: @tuplasuhveli (Elmeri Länsiharju) via transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

* [Tx] Updates for file translations/flowplayer.ts in fi (#95)

* Translate translations/flowplayer.ts in fi

100% translated source file: 'translations/flowplayer.ts'
on 'fi'.

* Translate translations/flowplayer.ts in fi

100% translated source file: 'translations/flowplayer.ts'
on 'fi'.

* Translate translations/flowplayer.ts in fi

100% translated source file: 'translations/flowplayer.ts'
on 'fi'.

* Translate translations/flowplayer.ts in fi

100% translated source file: 'translations/flowplayer.ts'
on 'fi'.

* Translate translations/flowplayer.ts in fi

100% translated source file: 'translations/flowplayer.ts'
on 'fi'.

* Translate translations/flowplayer.ts in fi

100% translated source file: 'translations/flowplayer.ts'
on 'fi'.

* Translate translations/flowplayer.ts in fi

100% translated source file: 'translations/flowplayer.ts'
on 'fi'.

* Translate translations/flowplayer.ts in fi

100% translated source file: 'translations/flowplayer.ts'
on 'fi'.

* Translate translations/flowplayer.ts in fi

100% translated source file: 'translations/flowplayer.ts'
on 'fi'.

---------

Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

* Translate translations/flowplayer.ts in fi (#96)

100% translated source file: 'translations/flowplayer.ts'
on 'fi'.

Authored-by: @tuplasuhveli via transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

* [extras/Lockscreen.qml] Add reference to issue #102 (#103)

Denote that this file currently comprises dead, problematic code; for details see issue #102.

* [src/utils.cpp] Remove function `startMafw` …

…, because it appears to be dead code; for details see issue #101.

* [src/utils.h] Remove function declaration `startMafw` …

…, because it appears to be dead code; for details see issue #101.

* [src/datareader.cpp] Omit superfluous `QString oFile` (#100)

For details, see #75 (comment)

* Use the app config dir to save the QSettings file (#105)

Sailjail is not mounting the generic config dir,
so the QSettings file should be under org/app/
dir and not under the org/ dir.

* [flowplayer/extras/Lockscreen.qml] Denote status in comments (#108)

See issue #102 for details.

* [flowplayer/src/playlist.cpp] Convert unused `/home/nemo` references, too (#107)

As discussed in issue #101.

* [flowplayer.changes] Add changelog entries for v0.3.6

* [flowplayer.spec] Pre-release version increase

* [README.md] Add Elmeri Länsiharju (tuplasuhveli) as contributor

* [flowplayer.changes] Beautify two atributions

* [flowplayer.changes] Another round of name beautifying

---------

Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
Co-authored-by: Damien Caliste <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request feature requests, suggestions, ideas etc.
Projects
None yet
Development

No branches or pull requests

1 participant