Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lastLoginField is not updated #101

Open
akuznetsov-gridgain opened this issue Sep 8, 2015 · 6 comments
Open

lastLoginField is not updated #101

akuznetsov-gridgain opened this issue Sep 8, 2015 · 6 comments

Comments

@akuznetsov-gridgain
Copy link

After upgrading to 1.2.0 I noticed that last login field is not updated any more.

It was updated on some previous version for sure.

Could someone check this?

@saintedlama
Copy link
Owner

The reason is that last login field is only updated when limitAttempts is activated.

@akuznetsov-gridgain
Copy link
Author

Thanks! That was a real reason indeed!

But, why lastLoginField updated only with limitAttempts ?
I think lastLoginField should be updated always? No?

@saintedlama
Copy link
Owner

To be honest it does not make sense 😄 The lastLoginField was introduced to make limitAttempts work but due to some bug the user model and thus lastLoginField was always updated. By fixing the bug the lastLoginField is no only updated in case limit limitAttempts is activated. It's arguable that only fields that are needed are added to the model but I'll see to find some "fix"

@tobysteward
Copy link

+1 - I reckon this field should exist regardless of limitAttempts or not.

@SabeehY
Copy link

SabeehY commented Jul 26, 2016

+1

@leoyli
Copy link

leoyli commented Oct 17, 2017

+1

And I think it should be addressed in the user guide before the enhancement is done... it confused some how...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants