-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lastLoginField is not updated #101
Comments
The reason is that last login field is only updated when limitAttempts is activated. |
Thanks! That was a real reason indeed! But, why lastLoginField updated only with limitAttempts ? |
To be honest it does not make sense 😄 The lastLoginField was introduced to make limitAttempts work but due to some bug the user model and thus lastLoginField was always updated. By fixing the bug the lastLoginField is no only updated in case limit limitAttempts is activated. It's arguable that only fields that are needed are added to the model but I'll see to find some "fix" |
+1 - I reckon this field should exist regardless of limitAttempts or not. |
+1 |
+1 And I think it should be addressed in the user guide before the enhancement is done... it confused some how... |
After upgrading to 1.2.0 I noticed that last login field is not updated any more.
It was updated on some previous version for sure.
Could someone check this?
The text was updated successfully, but these errors were encountered: