From e2fbfa7e004848f206c40c79c8ac69f3ecfa8fd5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jes=C3=BAs=20Alonso=20Madrid?= Date: Fri, 24 Jan 2025 11:14:33 +0100 Subject: [PATCH] SAK-50903 Creating a new assignment and putting it to site users creates an asn.new.assignment event, but this does not happen when putting it to selected groups. --- .../assignment/tool/AssignmentAction.java | 23 +++++-------------- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentAction.java b/assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentAction.java index 9baaaeef3ee2..7fd542b66935 100644 --- a/assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentAction.java +++ b/assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentAction.java @@ -9100,24 +9100,13 @@ private void post_save_assignment(RunData data, String postOrSave) { } if ((newAssignment && !a.getDraft()) || (!a.getDraft() && !newAssignment)) { - - Collection aGroups = a.getGroups(); - if (aGroups.size() != 0) { - // If already open - if (openTime.isBefore(Instant.now())) { - eventTrackingService.post(eventTrackingService.newEvent(AssignmentConstants.EVENT_UPDATE_ASSIGNMENT_ACCESS, assignmentReference, true)); - } else { - // Not open yet, delay the event - eventTrackingService.delay(eventTrackingService.newEvent(AssignmentConstants.EVENT_AVAILABLE_ASSIGNMENT, assignmentReference, - true), openTime); - } + // If already open + if (openTime.isBefore(Instant.now())) { + // post new assignment event since it is fully initialized by now + eventTrackingService.post(eventTrackingService.newEvent(AssignmentConstants.EVENT_ADD_ASSIGNMENT, assignmentReference, true)); } else { - if (openTime.isBefore(Instant.now())) { - // post new assignment event since it is fully initialized by now - eventTrackingService.post(eventTrackingService.newEvent(AssignmentConstants.EVENT_ADD_ASSIGNMENT, assignmentReference, true)); - } else { - eventTrackingService.delay(eventTrackingService.newEvent(AssignmentConstants.EVENT_AVAILABLE_ASSIGNMENT, assignmentReference, true), openTime); - } + // Not open yet, delay the event + eventTrackingService.delay(eventTrackingService.newEvent(AssignmentConstants.EVENT_AVAILABLE_ASSIGNMENT, assignmentReference, true), openTime); } } }