Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSR] className reflection should handle non-strings #5093

Open
nolanlawson opened this issue Jan 3, 2025 · 0 comments
Open

[SSR] className reflection should handle non-strings #5093

nolanlawson opened this issue Jan 3, 2025 · 0 comments

Comments

@nolanlawson
Copy link
Collaborator

Looking at our implementation of className in the SSR runtime, it seems we have a small bug, which is that we don't coerce to a string when you set it to a non-string, e.g.:

this.className = undefined // should be 'undefined'
this.className = null // should be 'null'
this.className = 0 // should be '0'
// etc.

This matches what browsers do in this case. Not sure about engine-server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant