You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The problem is that sometimes the messages which we are decoding do not have a __console_feed_remaining__0 entry at the end of the data array. This could be due to improper usage on our end. But the Decode function will always remove the last element of the data array regardless of what the element actually is. The code would be safer if it validated the entry before removing it, using code similar to this:
We've had some problems over on the p5 Web Editor with upgrading from
^3.2.0
to^3.5.0
.I've traced it back to the
Decode
function and the changes that were made there to support thelimit
option.console-feed/src/Transform/index.ts
Lines 18 to 23 in 19a2c05
The problem is that sometimes the messages which we are decoding do not have a
__console_feed_remaining__0
entry at the end of thedata
array. This could be due to improper usage on our end. But theDecode
function will always remove the last element of thedata
array regardless of what the element actually is. The code would be safer if it validated the entry before removing it, using code similar to this:console-feed/src/Component/react-inspector/index.tsx
Lines 199 to 202 in 19a2c05
The text was updated successfully, but these errors were encountered: