-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SLF4J logging system for the library #15
Comments
This seems like a good idea to me in theory. It does add additional dependencies, but ultimately almost every downstream project is going end up with a logging framework in addition to the htsjdk As long as:
Then I think it should be good. @tfenne I feel like you're the most likely to object, what do you think? |
For your requirements, I suggest to include an module (
|
That sounds good to me. A few hundred kb doesn't seem like a problem to me. |
Cool - once we have the build system (#14) I will add the proposed module. |
Instead of porting the
Log
class from HTSJDK I propose to use SLF4J instead to let the API user to choose the logging framework that they want.The configuration will be to add
slf4j
as a compile dependency and some implementation for testing (e.g.,org.slf4j:slf4j-simple
). Promatically setting verbosity should be done by downstream application or passing aorg.slf4j.Logger
that can be configure by the caller. This can also allow to switch off the verbosity for the library and output only the logs for the downstream application.Any objections @samtools/htsjdk-next-maintainers?
The text was updated successfully, but these errors were encountered: