-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve how to handle issues with supporting Windows #35
Comments
I think that we are mixing here two different questions: 1) how line-endings in tests will be handled to be both Windows/Linux compatible and avoid check-in (this topic); 2) if we really need #34, and how we can provide a proper way to pass non-Path URIs in a proper way. For the later, I recommend other issue for opening discussion about the better design or just discusss on the PR. |
Yes, please, lets keep the discussion around #34 in that PR, rather than here. The issues here are independent of it; I only mentioned it here because its what brought these issues to my attention. |
If we're going to support windows, there are some issues, some subtle and some not, that we should probably address sooner rather than later. (#34 is is failing when the tests run on Windows).
Line endings. For source code, test files, and more subtly, text files that have indices that contain offsets, i.e. fasta. We could configure the repo to handle them, but I don't think that would prevent a Windows user from submitting a compressed file with Windows line endings (though I'm not clear on whether all binary types need to be exempted as described in the article). We recently had a GATK developer who submitted a branch developed on Windows - the tests succeeded locally but were failing somewhat mysteriously on travis due to index offset issues caused by line ending differences.
Path separator interconversion. We're going to need a way to reference test files from within tests that work on all platforms (once we figure out where test files live, that is). Many of the tests in URI and Path specifier classes for input/output resources. #34 are intended to validate that raw input paths from a user are normalized and handled correctly. Preprocessing the inputs using
Paths
orURI
defeats the purpose, as these perform other transformations.The text was updated successfully, but these errors were encountered: