Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token security #36

Open
j1m-renwick opened this issue Jun 23, 2020 · 0 comments
Open

Token security #36

j1m-renwick opened this issue Jun 23, 2020 · 0 comments

Comments

@j1m-renwick
Copy link

I'm by no means an expert on google api tokens, but it doesn't seem great that they're exposed to the client as a matter of course. I think there's a couple of things that could be done to reduce the risk that exposing the token poses:

  1. Add more detailed README text specifying that the Google token generated should be restricted to the Google Fonts API being called from their specific website (I realise that advising people on how to configure API tokens isn't really your problem, but I do think it would help people to use your component properly)

  2. Consider an alternative to specifying the API token in the code directly - maybe it could be a function that retrieves the data some other way (e.g. calling to a backend server that holds the api token and proxies the request)?

@rcrym rcrym mentioned this issue May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant