Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/highlight-words-core is required #15

Open
guicara opened this issue Dec 17, 2021 · 2 comments
Open

@types/highlight-words-core is required #15

guicara opened this issue Dec 17, 2021 · 2 comments

Comments

@guicara
Copy link

guicara commented Dec 17, 2021

Hello,

First of all, thank you for this great library!

The library @types/highlight-words-core should not be on the devDependencies, but directly on the dependencies. Otherwise, a TypeScript error occurred when using your component: the props searchWords is unknown. I had to manually add @types/highlight-words-core in my dependencies.

So, the README should be changed from:

yarn add @sanar/react-native-highlight-text

... to:

yarn add @sanar/react-native-highlight-text @types/highlight-words-core
@ghost
Copy link

ghost commented Aug 23, 2022

Thanks thats really helpful

@thoth-seshat
Copy link

Thanks, was just looking this up. We should add this to the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants