253 feature create form instance flow #297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…53-feature-create-form-instance-flow
…b.com/sandboxnu/mfa-form-automator into 253-feature-create-form-instance-flow
2 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
elvincheng3
reviewed
Feb 21, 2025
| disabled={disabled} | ||
| review={review} | ||
| /> | ||
| {isFormTemplate ? ( |
There was a problem hiding this comment.
I think we can consolidate this conditional to:
<FormButtons
isFormTemplate={isFormTemplate}
heading=`Create Form ${isFormTemplate ? "Template" : "Instance" }`
deleteFunction={deleteFunction}
submitLink={submitLink}
backLink={backLink}
disabled={disabled}
review={review}
/>```
There was a problem hiding this comment.
@kaiyangzheng also says that we need to add a home button at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created flow pages for when creating a form instance.
Motivation and Context
Allows users to create form instances in a similar flow as form templates and assign users to field groups
How has this been tested?
Created form instances from pre-existing form templates.
Screenshots (if appropriate):
Types of changes
Also added signaturePosition fields to formInstanceContext so assignees can be saved and shown on review page.
Checklist:
What is the code style and how do i run tests?