Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: pass options to cucumber cli #20

Open
briandunn opened this issue Dec 29, 2010 · 1 comment
Open

Feature request: pass options to cucumber cli #20

briandunn opened this issue Dec 29, 2010 · 1 comment

Comments

@briandunn
Copy link

I need to be able to filter the features that are run on tag, like --tags ~@wip
I have forked this repo and my first attempt is as follows, borrowing the convention of ENV['CUCUMBER_OPTS'] from cucumber.rake.

https://github.com/briandunn/specjour/blob/master/lib/specjour/cucumber/runner.rb

This doesn't seem to affect the listeners, presumably because the environment of dispatch is not available. Do you have any thoughts on how something like this should be communicated to the listeners?

@sandro
Copy link
Owner

sandro commented Jan 1, 2011

Thanks for the patches! I'm on vacation at the moment but will be sure to pull in those deprecation fixes when I get back home. As for the cucumber options, I've been wanting to add those for some time but have been unsure of the best way to do it. They probably have to be communicated from the dispatcher to the manager down to the worker. Take a look at the worker_options method in manager.rb. Most of those options get set on the manager by the dispatcher directly (see #set_up_manager in dispatcher.rb). The simplest solution I see is to just follow that pattern. The dispatcher sets the cucumber options on the manager which gets set on the worker. Not an elegant solution but specjour isn't especially elegant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants