Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download spk button doesn't actually set filename #142

Open
ocdtrekkie opened this issue Apr 29, 2021 · 1 comment
Open

Download spk button doesn't actually set filename #142

ocdtrekkie opened this issue Apr 29, 2021 · 1 comment

Comments

@ocdtrekkie
Copy link
Collaborator

So I noticed, the download spk feature is written to rename the spk to something reasonable, via the download attribute on the a tag: ea43994

However, interestingly... it doesn't. I am assuming the issue is that we have a link, and then inside it, is a div button thing, and we're hitting the div button, not the original link?

@ocdtrekkie
Copy link
Collaborator Author

It has nothing to do with the div, if you remove it the behavior is the same... I think the root of it is here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a where it says "download only works for same-origin URLs, or the blob: and data: schemes."

app-index.sandstorm.io and apps.sandstorm.io are different origins, which is why that attribute doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant