Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviews should specify the app version they apply to #71

Open
paulproteus opened this issue Jul 28, 2016 · 3 comments
Open

Reviews should specify the app version they apply to #71

paulproteus opened this issue Jul 28, 2016 · 3 comments

Comments

@paulproteus
Copy link
Collaborator

Context:

  • As a user of an app, I want to have a sense of which reviews are relevant to me consuming the latest version of an app.
  • As an app author, when I fix a bug in an app and push a review to the app market, the pain of seeing bad reviews that no longer affect my users is diminished.
  • Reviews should be in newest-first order #54 requested newest-first as well as this feature; I'm splitting the version-number stuff into this separate issue since it requires some design input.

Proposal:

  • When a review is being submitted, a text field should appear asking the user what version of the app this review applies to.
  • This should be pre-filled with the appMarketingVersion that is current for this app in the app market. (IMHO it shouldn't be the versionNumber because the user never sees versionNumber in the Sandstorm shell.)
  • We should store this with a review.
  • When rendering reviews, if the appMarketingVersion in the review is not equal to the current appMarketingVersion, then we show a label such as "For an older version" indicating that this review isn't current.
  • When rendering reviews, we do not show the full version info that the person placed into that text field.

References:

Next steps:

  • @neynah would need to make a mockup so that there is a visual design that is consistent with the app market, rather than my sort-of-random proposal above (which admittedly is based on the Google Play store).
@neynah
Copy link
Collaborator

neynah commented Jul 28, 2016

Just an editable field of text. Perhaps we should allow users to submit it with an empty field (in the case where they may not know the version number)?

(Don't mind/bother with the review styling below, I will restyle.)

app-market-review-version

@ocdtrekkie
Copy link
Collaborator

Does this need to be editable, or should it just use the current appMarketingVersion? People generally should not be submitting reviews on old versions of an app.

@matbrgz
Copy link

matbrgz commented Mar 10, 2017

@ocdtrekkie i think in automatically add version, not editable. Copy from app manifest and places at review metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants