Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup of apidev functions #4

Open
funderburkjim opened this issue Aug 7, 2019 · 3 comments
Open

cleanup of apidev functions #4

funderburkjim opened this issue Aug 7, 2019 · 3 comments

Comments

@funderburkjim
Copy link
Contributor

There are some functions, class methods, etc. that are no longer used. These should be removed so they don't clutter the current code base.

@funderburkjim
Copy link
Contributor Author

getword_data_html

This is in module getword_data.php.
It was written when precomputed html was being used; as mentioned elsewhere, precomputed html is no longer used in the apidev system. In particular the getword_data_html function is called nowhere. So, this function can be deleted.

Note: The function getword_data_html_raw is used instead.
This function is called only by modules getword.php and servepdf.php.

@funderburkjim
Copy link
Contributor Author

get1_basic

This method of class Dal (in dal.php) is never used. Hence can be deleted.

@funderburkjim
Copy link
Contributor Author

getword_data_html_raw -> getword_data_html

Now that we got rid of the unused 'getword_data_html' function in getword_data, we can rename the
getword_data_html_raw function to just getword_data_html -- no need for the '_raw' suffix.

This requires changes in

  • getword_data.php where function is defined
  • getword.php where function is called
  • servepdf.php where function is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant