collection: Regression in GitHub workflows after merging PR 610

[berndfinger]

The error message is:

[Invalid workflow file: .github/workflows/ansible-lint-sap_maintain_etc_hosts.yml#L1](https://github.com/sap-linuxlab/community.sap_install/actions/runs/7651827742/workflow)
No steps defined in `steps` and no workflow called in `uses` for the following jobs: ansible-lint

[berndfinger]

After a first look, it seems that the steps: section is required. @Wabri - Can you please have a look?
Here's a link to one of the failing action: https://github.com/sap-linuxlab/community.sap_install/actions/runs/7652044239
And a direct link to the changed files of PR #610: https://github.com/sap-linuxlab/community.sap_install/pull/610/files

[berndfinger]

The steps: section is however in .github/workflows/ansible-lint-sap_reusable_workflow.yml.

[ja9fuchs]

Currently the reusable workflow file does not yet exist in the main branch.

That is probably the reason why the following

uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml**@main**

is not valid and causes an error.

I suggest merging this new reusable workflow file into main first in a separate PR.

[Wabri]

Yes, I pointed it out this problem in this comment #610 (comment)

Maybe now we should try to run one of the action that went into that error and check if is ok

[berndfinger]

Yes, I pointed it out this problem in this comment #610 (comment)

Thanks! I had read it but didn't pay enough attention to it.

Maybe now we should try to run one of the action that went into that error and check if is ok

The file is now part of the main branch. I created a test role with a GitHub reusable workflow, see https://github.com/berndfinger/testrole01/tree/dev/.github/workflows. None of my attempts to switch from a normal to a reusable workflow was successful so far.

@Wabri Can you please share an example of a configuration which has worked for you?

[berndfinger]

Finally now working in my example, see https://github.com/berndfinger/testrole01/actions/runs/7667462910 .

[Wabri]

Awesome 🚀

[berndfinger]

@Wabri Unfortunately, it only helped in my test case. Now working on:

• trying to get the workflows to work in my fork. Maybe I can use a variable for the GitHub organization.
• getting a little code change into dev, to verify that the workflows are actually working.
• once that is done, implement the manual trigger for all workflows so that we can better test them.

From looking at https://github.com/Wabri/community.sap_install/actions, it seems the new reusable workflow hasn't worked for you. Are you still confident that it will work for this upstream repo?

[berndfinger]

@Wabri Maybe I solved it, see PR #627 . I set you as one of the reviewers.

[Wabri]

It works for me: https://github.com/Wabri/community.sap_install/actions/runs/7671846479

[Wabri]

Saw the problem, I put too many layers in the jobs section!

[berndfinger]

Hopefully solved by #627. Let's wait and see... :-)

[berndfinger]

I think we can close this issue now. No more problems showed up.