Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page head element does not change when navigating between pages #90

Open
budak7273 opened this issue Jun 28, 2023 · 4 comments · May be fixed by #184
Open

Page head element does not change when navigating between pages #90

budak7273 opened this issue Jun 28, 2023 · 4 comments · May be fixed by #184
Labels
bug Something isn't working

Comments

@budak7273
Copy link
Member

budak7273 commented Jun 28, 2023

Example:

  1. Navigate directly to this link: https://ficsit.app/mod/FicsitRemoteMonitoring
  2. Notice the page title is FicsitRemoteMonitoring - SMR
  3. Click the "home" link on the page
  4. Notice the page title is still FicsitRemoteMonitoring - SMR
  5. Navigate directly to this link in a new tab: https://ficsit.app/
  6. Notice the page title is Home - SMR
@budak7273 budak7273 converted this from a draft issue Jun 28, 2023
@budak7273 budak7273 added the bug Something isn't working label Jun 28, 2023
@budak7273
Copy link
Member Author

Might be resolved by the framework update, see https://discord.com/channels/555424930502541343/830842478956642354/1123695901039415307

@budak7273 budak7273 moved this from 🆕 New to 📋 Backlog in Mod Repository (SMR) Jun 28, 2023
@budak7273 budak7273 changed the title Page header does not change when navigating between pages Page head element does not change when navigating between pages Jun 28, 2023
@budak7273
Copy link
Member Author

elements in head are being duplicated. should:tm: be resolved by svelte 4
https://discord.com/channels/555424930502541343/830842478956642354/1126043859542081606

@budak7273 budak7273 moved this from 📋 Backlog to ⛔ Blocked in Mod Repository (SMR) Jul 5, 2023
@budak7273
Copy link
Member Author

sveltejs/kit#10089

@QuantumPickleJar
Copy link

With a simplified load function in +page.ts, the tags don't seem to be getting duplicated anymore, though I'm having some difficulty verifiying this as I get a ton of networking errors trying to check FicsitRemoteMonitoring (for example).

Reduced Load Function:
// src/routes/+page.ts

export const load = async () => ({
  meta: {
    title: 'Mods',
    description: 'Mods available from the Satisfactory Mod Repository',
    image: '/assets/favicon.ico',
  },
});

@budak7273 budak7273 linked a pull request Sep 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

2 participants