Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time_line problems #9

Open
orchestr7 opened this issue Aug 30, 2023 · 3 comments
Open

Time_line problems #9

orchestr7 opened this issue Aug 30, 2023 · 3 comments
Assignees

Comments

@orchestr7
Copy link
Member

  1. Mistake in spelling: should be not time_line, but timeline
  2. Timeline should not contain found and fixed types. As these types are already there in the events Patch details problems #8
@JustinB1eber
Copy link

Actually you can see the COSV-schema document, these already in the time_line examples.
And current design can already meet the requirements.

"time_line": [
    {
      "type": "found",
      "value": "2023-02-13T16:43Z"
    },
    {
      "type": "fixed",
      "value": "2023-03-13T16:43Z"
    }
]

@orchestr7
Copy link
Member Author

As we discussed with @nulls disclosed type is the only actually type that cannot be calculated from events:

  • found can be taken from affected
  • fixed also can be taken from affected
  • introduced can be calcualated

My suggestion to leave only disclosed in timeline by for now.

@nulls
Copy link
Member

nulls commented Sep 6, 2023

Also, as a simple enhancement, we can use format like in events:
Instead of

"time_line": [
    {
      "type": "found",
      "value": "2023-02-13T16:43Z"
    },
    {
      "type": "fixed",
      "value": "2023-03-13T16:43Z"
    }
]

write

"time_line": [
    {
      "found": "2023-02-13T16:43Z"
    },
    {
      "fixed": "2023-03-13T16:43Z"
    }
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants