source has no method shutdown ?

[Russsgithub]

Describe the bug
I just checked one of my scripts (which worked well not so long ago) and I'm getting

s.shutdown()

Error 5: this value has no method `shutdown`

I've simplified things below and get the same error.

This is in a dynamic source stream relay type script and I see the recommended instigation has changed.

Has the shutdown() method been removed/changed

To Reproduce

s =  mksafe(sine(440.)
out = output.dummy(s)

s.shutdown()
out.shutdown()

Expected behavior
script to shutdown gracefully

Version details

• OS: [e.g. Debian, OSX] - Ubuntu 20.04
• Version [e.g. 1.3.4] - 2.1

Install method
Opam

[smimram]

It was removed in 2c51f12 because shutdown only makes sense for active outputs I think: in this case shutdown on out should be enough.

[Russsgithub]

Thanks @smimram , I'm still having problems with this.

s = sine(440.)

out = output.icecast(fallible=true, description="Sound Mirror", icy_metadata="true", format="audio/aac", %fdkaac(channels=2, samplerate=48000, bitrate=320, bandwidth=20000,afterburner=true, transmux="adts", aot="mpeg4_aac_lc", sbr_mode=false), host="localhost", port=8000, password="hackme",mount="test",s)


out.shutdown()

gives this error

Error -1: Exception raised: File "source.ml", line 780, characters 53-59: Assertion failed
Raised at Source.Clock_variables.get in file "source.ml", line 780, characters 53-65
Called from Start_stop.meth.(fun) in file "tools/start_stop.ml", line 181, characters 14-33
Called from Evaluation.apply.f in file "lang/evaluation.ml", line 315, characters 8-12
Called from Evaluation.eval_toplevel in file "lang/evaluation.ml", line 493, characters 16-22
Called from Runtime.type_and_run.(fun) in file "lang/runtime.ml", line 38, characters 13-43
Called from Tutils.finalize in file "tools/tutils.ml", line 105, characters 12-16
Re-raised at Tutils.finalize in file "tools/tutils.ml", line 111, characters 4-38
Called from Runtime.report in file "lang/runtime.ml", line 191, characters 12-23

[smimram]

This now looks like a real bug... @toots ?

[pixline]

Hi, I can confirm we have the same bug with Liquidsoap >= 2.0.0:

Liquidsoap 2.0.2

Error -1: Exception raised: File "source.ml", line 855, characters 53-59: Assertion failed
Raised at Source.Clock_variables.get in file "source.ml", line 855, characters 53-65
Called from Lang.source_methods.(fun) in file "lang/lang.ml", line 753, characters 12-31
Called from Evaluation.apply.f in file "lang/evaluation.ml", line 250, characters 8-12
Called from Evaluation.eval_toplevel in file "lang/evaluation.ml", line 417, characters 16-22
Called from Runtime.type_and_run.(fun) in file "lang/runtime.ml", line 38, characters 13-43
Called from Tutils.finalize in file "tools/tutils.ml", line 100, characters 12-16
Re-raised at Tutils.finalize in file "tools/tutils.ml", line 106, characters 4-38
Called from Runtime.report in file "lang/runtime.ml", line 227, characters 12-23

Liquidsoap 2.0.1/2.0.0

Error -1: Exception raised: File "source.ml", line 842, characters 53-59: Assertion failed
Raised at Source.Clock_variables.get in file "source.ml", line 842, characters 53-65
Called from Lang.source_methods.(fun) in file "lang/lang.ml", line 738, characters 12-31
Called from Evaluation.apply.f in file "lang/evaluation.ml", line 250, characters 8-12
Called from Evaluation.eval_toplevel in file "lang/evaluation.ml", line 417, characters 16-22
Called from Runtime.type_and_run.(fun) in file "lang/runtime.ml", line 38, characters 13-43
Called from Tutils.finalize in file "tools/tutils.ml", line 100, characters 12-16
Re-raised at Tutils.finalize in file "tools/tutils.ml", line 106, characters 4-38
Called from Runtime.report in file "lang/runtime.ml", line 191, characters 12-23

Liquidsoap installed via Opam, test script used:

b = blank( duration = 10. )
out = output.dummy( b )
out.shutdown()

Hope it helps!

[toots]

Thanks for reporting y'all. This is fixed in v2.0.4-preview and main.

[Russsgithub]

I have found a work around for my problem.
I was trying to store multiple source / output shutdown methods in a list, which I have been doing like this

streams = []

...
...
s = if x then 
        input.http(....,url)
      else
         input.rtmp(...)
       end
       
o = if y then
        output.icecast(...,foo, s)
      else
        output.icecast(...,bar, s)
      end

def shutdown()
  s.shutdown()
  out.shutdown()
end

streams := list.add((id, shutdown), !streams)

This no longer seems to work.
After looking at the docs for dynamic sources (i think) I got this working

streams = []
src_shutdown = []
out_shutdown = []

def src(.....)
  if x then 
    s = input.http(....,url)
    src_shutdown = := [(string.id(id), s.shutdown)]
    s
  else
    input.rtmp(...)
    src_shutdown = := [(string.id(id), s.shutdown)]
    s
  end
end
       
#### and similar here to above
o = output.icecast(...)

def shutdown()
  head = list.hd(!src_shutdown)
  shutdown = snd(head)
  shutdown()
  #### and similar with output (o)
end

streams := list.add((id, shutdown), !streams)

It feels a little over complicated, but works. I'm sure there is a prettier way.