Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciated packages #2

Closed
robsox opened this issue May 16, 2023 · 1 comment
Closed

Depreciated packages #2

robsox opened this issue May 16, 2023 · 1 comment

Comments

@robsox
Copy link

robsox commented May 16, 2023

Hi, nice job on this real world app.
I noticed two installing stopping problems due to the lararavel 10 upgrade though.
Fideloper\TrustProxy and fruitcake\cors were integrated into Laravel as of version 9 so are causing an issue with composer compatibility.
I changed "use Fideloper\Proxy\TrustProxies as Middleware;" to "use Illuminate\Http\Middleware\TrustProxies as Middleware;" in TrustProxies.php and changed headers per fideloper/TrustedProxy#152 then
replaced "\Fruitcake\Cors\HandleCors::class," with "\Illuminate\Http\Middleware\HandleCors::class," in app/Http/Kernel.php per https://github.com/fruitcake/laravel-cors and everything worked perfectly. I would have done a pull request, but it seemed silly for such minor changes.
Thanks for your effort on this,
Rob

@sawirricardo
Copy link
Owner

Thanks, have fixed this @robsox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants