Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish for Scala.js 1.0 #265

Closed
SethTisue opened this issue Feb 14, 2020 · 15 comments
Closed

publish for Scala.js 1.0 #265

SethTisue opened this issue Feb 14, 2020 · 15 comments
Assignees

Comments

@SethTisue
Copy link
Member

No description provided.

@SethTisue
Copy link
Member Author

SethTisue commented Feb 14, 2020

@eed3si9n asked how does back-publishing work in this repo?

@lrytz and I were just discussing this with @ashawley in the scala-xml repo: scala/scala-xml#406 (comment)

there's two choices:

  1. push a commit that removes the stuff you don't want published
  2. go ahead and republish everything but then drop all of the staging repos except the one you actually wanted

1 is a bit more elegant and generates less atmospheric carbon. I sorta threw 2 out there, but 1 seems better tbh

@SethTisue
Copy link
Member Author

I opened sbt/sbt-ci-release#102 to see if Olaf has an “official” position on this

@Philippus
Copy link
Member

We did it like 1 last time for scala native. See 373091b.

@SethTisue
Copy link
Member Author

SethTisue commented Feb 18, 2020

@Philippus looks like the discussion over on the sbt-ci-release ticket has run its course. want to try publishing, along the lines Lukas suggests?

@SethTisue
Copy link
Member Author

if you have time to tackle it this weekend, great; otherwise, I can do it on Tuesday

@Philippus
Copy link
Member

Philippus commented Feb 22, 2020

I've created a release tag here: https://github.com/scala/scala-parser-combinators/releases/tag/v1.1.2%23scalajs100%238
and build is here: https://travis-ci.org/scala/scala-parser-combinators/builds/653772816

One thing to note is that I didn't touch the scala 2.12 and 2.13 versions so it is compiled against 2.12.8 and 2.13.0 (just like the other releases of version 1.1.2).

@Philippus
Copy link
Member

I'm getting a "iv undefined" on the build. Seems to be something related to ssl.

@SethTisue
Copy link
Member Author

@lrytz's fix for same issue in scala-xml repo: scala/scala-xml#418

@lrytz
Copy link
Member

lrytz commented Feb 25, 2020

I'll do the backport here as well.

@Philippus
Copy link
Member

Thank you @lrytz , shall I delete the release tag?

@lrytz
Copy link
Member

lrytz commented Feb 25, 2020

👍, we can re-do it once everything's ready

@lrytz
Copy link
Member

lrytz commented Feb 28, 2020

With #268 merged, releasing from the 1.1.x branch should work. If you want to re-release 1.1.2 for Scala.js 1.0, you need to create a commit that removes everything from the build matrix that's not needed, and tag that with v1.1.2#some-suffix.

@Philippus
Copy link
Member

The tag is here: https://github.com/scala/scala-parser-combinators/releases/tag/v1.1.2%23scalajs100, and the build is green!

@eed3si9n
Copy link
Member

Looks like these are in staging repositories on Sonatype OSS. I'll push these out to release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants