Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better dealing of undefined/non-measured particle widths #140

Closed
eduardo-rodrigues opened this issue Jun 6, 2019 · 2 comments
Closed

Better dealing of undefined/non-measured particle widths #140

eduardo-rodrigues opened this issue Jun 6, 2019 · 2 comments
Labels
🐛 bug Something isn't working
Milestone

Comments

@eduardo-rodrigues
Copy link
Member

Several known particles have no measured value of their width, e.g. the D∗(2007)0, with a width < 2.1 MeV @ 90% confidence level (see PDGLive). The present code shows

>>> p = Particle.from_pdgid(423)
>>> print(p.width, p.width_lower, p.width_upper)
2.1 1.0 -1.0

, which is "digested information" from the PDG particle data table: the .mcd file contains empty fields for the 3 quantities whereas the 2018 extended file flags the experimental upper limit with the values 2.1,-1,-1 (the fact the width_lower is +1 in the print out above is because all errors are converted to positive numbers in our converter code that produces the CSV file we use).

We need to improve the above on 2 fronts:

  1. print(p.width, p.width_lower, p.width_upper) should rather return 2.1 -1.0 -1.0 for this kind of cases, so that the user can see the errors are not known. The documentation could and should mention this special case.
    Some code such as df.loc[df['WidthLower'] != -1, 'WidthLower'] = 1 could do the trick.

  2. With the special -1.0 values for the width errors the method Particle.describe() could catch these and print the particle width as Width < 2.1 MeV whereas now it prints Width = 2.1 ± 1.0 MeV, which is wrong and misleading.

One should also look at the mass and mass error entries to catch similar issues.

@eduardo-rodrigues eduardo-rodrigues added the 🐛 bug Something isn't working label Jun 6, 2019
@eduardo-rodrigues
Copy link
Member Author

Better do this only once PRs #137 and #139 are merged.

@eduardo-rodrigues
Copy link
Member Author

Closed via #142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant