Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning for descoteaux basis #865

Closed
EmmaRenauld opened this issue Dec 15, 2023 · 2 comments
Closed

Warning for descoteaux basis #865

EmmaRenauld opened this issue Dec 15, 2023 · 2 comments

Comments

@EmmaRenauld
Copy link
Contributor

When running scil_dwi_to_sh:

PendingDeprecationWarning: The legacy descoteaux07 SH basis uses absolute values for negative harmonic degrees. It is outdated and will be deprecated in a future DIPY release. Consider using the new descoteaux07 basis by setting the legacy parameter to False.
@CHrlS98
Copy link
Contributor

CHrlS98 commented Dec 18, 2023

I changed the definitions of SH bases in DIPY back in 2020 to agree with the versions described in the cited papers. There is most likely also a warning for the Tournier basis. I think first a first step would be to update the add_sh_basis_arg method to support legacy and non-legacy bases.

@arnaudbore
Copy link
Contributor

#921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arnaudbore @EmmaRenauld @CHrlS98