Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cruise control kick in only after 50% throttle. M365 regular latest shfw #44

Closed
AlexS-hub opened this issue Feb 20, 2024 · 8 comments
Closed
Assignees
Labels
bug Something isn't working high we should start worrying shfw shfw bugs

Comments

@AlexS-hub
Copy link

Scooterhacking Tool

Firmware (SHFW)

Type of issue

Performance issue

Severity of issue

high (major functionality broken, no workaround)

SHUT Version

2.3.2

SHFW Version

0.3.6

Scooter model

Xiaomi M365

Description of the Bug

All modes of cruise control activate only with 50% throttle or more.

Steps to Reproduce

Turn on scooter apply 30 throttle, no cruise control

Expected vs. Actual Behavior

Cruise control kicks in, it doesn't

Contact Information

[email protected]

@AlexS-hub AlexS-hub added the bug Something isn't working label Feb 20, 2024
@github-actions github-actions bot added high we should start worrying shfw shfw bugs labels Feb 20, 2024
@paulederbaus
Copy link
Contributor

paulederbaus commented Feb 21, 2024

How are you using cruise control?

If you use time, the throttle value needs to be above the min value of hall sensor settings. Here the speed change is also checked. The speed needs to be steady to enable cc.

If you are using single / double tap, the value is hardcoded to 100. This means it depends on your throttle. With a good working throttle, this should be around 40%.
(A good working throttle goes from 40 to 190.)

@paulederbaus paulederbaus self-assigned this Feb 21, 2024
@AlexS-hub
Copy link
Author

AlexS-hub commented Feb 21, 2024 via email

@AlexS-hub
Copy link
Author

AlexS-hub commented Feb 21, 2024

Power based cc also has 50%-100% throttle activation range. I use pro for 4 dot ble from telegram shfw official channel.

@paulederbaus
Copy link
Contributor

If you dm me your uid via discord (paulederbaus), I can assign you an improved version.

@AlexS-hub
Copy link
Author

If you dm me your uid via discord (paulederbaus), I can assign you an improved version.

You mean that you have ble that works correctly?

@lekrsu
Copy link
Collaborator

lekrsu commented Feb 21, 2024

If you dm me your uid via discord (paulederbaus), I can assign you an improved version.

You mean that you have ble that works correctly?

Why are we mixing BLE into this now?

@paulederbaus
Copy link
Contributor

Issue closed - small adjustment of throttle diff and speed diff per loop

@AlexS-hub
Copy link
Author

Issue closed - small adjustment of throttle diff and speed diff per loop

It means i can flash shfw now and it will work like it should?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high we should start worrying shfw shfw bugs
Projects
None yet
Development

No branches or pull requests

3 participants