From d89336232efca66680c5715b0784f6620dcfd712 Mon Sep 17 00:00:00 2001 From: Vonny Jap Date: Fri, 24 Jan 2025 17:29:21 -0800 Subject: [PATCH] feat(3266): fixed unit tests for banner (#3270) --- package.json | 4 ++-- test/plugins/banner.test.js | 4 +++- test/plugins/data/banner.json | 2 ++ test/plugins/data/banners-active.json | 2 ++ test/plugins/data/banners.json | 6 ++++++ 5 files changed, 15 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 2c020d8b1..08ad5d5a0 100644 --- a/package.json +++ b/package.json @@ -109,7 +109,7 @@ "screwdriver-config-parser": "^11.0.0", "screwdriver-coverage-bookend": "^2.0.0", "screwdriver-coverage-sonar": "^4.1.1", - "screwdriver-data-schema": "^24.1.0", + "screwdriver-data-schema": "^24.2.0", "screwdriver-datastore-sequelize": "^9.0.0", "screwdriver-executor-base": "^10.0.0", "screwdriver-executor-docker": "^7.0.0", @@ -118,7 +118,7 @@ "screwdriver-executor-queue": "^5.0.0", "screwdriver-executor-router": "^4.0.0", "screwdriver-logger": "^2.0.0", - "screwdriver-models": "^31.0.0", + "screwdriver-models": "^31.1.0", "screwdriver-notifications-email": "^4.0.0", "screwdriver-notifications-slack": "^6.0.0", "screwdriver-request": "^2.0.1", diff --git a/test/plugins/banner.test.js b/test/plugins/banner.test.js index 41081dfa9..81c0018ba 100644 --- a/test/plugins/banner.test.js +++ b/test/plugins/banner.test.js @@ -104,6 +104,7 @@ describe('banner plugin test', () => { const message = 'Test banner example'; const isActive = true; const type = 'info'; + const scope = 'GLOBAL'; beforeEach(() => { options = { @@ -112,7 +113,8 @@ describe('banner plugin test', () => { payload: { message, isActive, - type + type, + scope }, auth: { credentials: { diff --git a/test/plugins/data/banner.json b/test/plugins/data/banner.json index 401c0a00e..67c0c2728 100644 --- a/test/plugins/data/banner.json +++ b/test/plugins/data/banner.json @@ -3,6 +3,8 @@ "message": "Test banner example", "isActive": true, "type": "info", + "scope": "GLOBAL", + "scopeId": null, "createdBy": "jimgrund", "createTime": "2017-01-06T01:49:50.384359267Z" } diff --git a/test/plugins/data/banners-active.json b/test/plugins/data/banners-active.json index 0909a3da5..d297d16a7 100644 --- a/test/plugins/data/banners-active.json +++ b/test/plugins/data/banners-active.json @@ -4,6 +4,8 @@ "message": "Test banner example", "type": "info", "isActive": true, + "scope": "GLOBAL", + "scopeId": null, "createdBy": "batman123", "createTime": "2017-01-06T01:49:50.384359267Z" } diff --git a/test/plugins/data/banners.json b/test/plugins/data/banners.json index d822bb4bd..67bb97f65 100644 --- a/test/plugins/data/banners.json +++ b/test/plugins/data/banners.json @@ -4,6 +4,8 @@ "message": "Test banner example", "type": "info", "isActive": true, + "scope": "GLOBAL", + "scopeId": null, "createdBy": "batman123", "createTime": "2017-01-06T01:49:50.384359267Z" }, @@ -12,6 +14,8 @@ "message": "Test banner example again", "type": "info", "isActive": false, + "scope": "GLOBAL", + "scopeId": null, "createdBy": "batman123", "createTime": "2017-01-07T01:49:50.384359267Z" }, @@ -20,6 +24,8 @@ "message": "Test banner example yet again", "type": "warn", "isActive": false, + "scope": "GLOBAL", + "scopeId": null, "createdBy": "batman123", "createTime": "2017-01-08T01:49:50.384359267Z" }