Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching between smooth and flat shading in OBJ preview #22

Closed
sczerwinski opened this issue Aug 7, 2020 · 2 comments
Closed

Switching between smooth and flat shading in OBJ preview #22

sczerwinski opened this issue Aug 7, 2020 · 2 comments
Assignees
Labels
component:3d 3D preview and OpenGL priority:low Will be done when will be done resolution:invalid This doesn't seem right type:feature New feature or request

Comments

@sczerwinski
Copy link
Owner

glShadeModel should be changed based on the value of s flag:

  • s offGL_FLAT
  • s 1GL_SMOOTH

This change might occur multiple times while drawing a single model.

@sczerwinski sczerwinski added type:feature New feature or request status:new Awaiting triage labels Aug 7, 2020
@sczerwinski sczerwinski self-assigned this Aug 7, 2020
@sczerwinski sczerwinski added status:todo Selected for development priority:medium Scheduled for next release and removed status:new Awaiting triage labels Aug 7, 2020
@sczerwinski sczerwinski added this to the 0.3 milestone Aug 8, 2020
@sczerwinski sczerwinski added the component:3d 3D preview and OpenGL label Feb 4, 2021
@sczerwinski sczerwinski modified the milestones: 0.3.x, 1.0.x Feb 4, 2021
@sczerwinski
Copy link
Owner Author

Should this change mean switching to another shader (performance improvement) or should it be reflected in the mesh loaded from an OBJ file (implementation simplicity)?

@sczerwinski
Copy link
Owner Author

Since there are multiple smoothing groups possible (see #149), expected behaviour of the 3D preview is not obvious.

Also, according to OBJ file type documentation:

However, vertex normals override smoothing information for Image.

Seems like smoothing groups are only useful for automated normal calculations, covered in #36.

@sczerwinski sczerwinski removed this from the 1.0.x milestone Jul 1, 2021
@sczerwinski sczerwinski added priority:low Will be done when will be done resolution:invalid This doesn't seem right and removed status:todo Selected for development priority:medium Scheduled for next release labels Nov 11, 2021
@sczerwinski sczerwinski closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:3d 3D preview and OpenGL priority:low Will be done when will be done resolution:invalid This doesn't seem right type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant