From 1b39dcb5926a858ceee228f649ee3fdb0c573de6 Mon Sep 17 00:00:00 2001 From: "sweep-ai[bot]" <128439645+sweep-ai[bot]@users.noreply.github.com> Date: Thu, 1 Feb 2024 15:16:07 +0000 Subject: [PATCH 1/4] feat: Updated docs/BuildSource.md --- docs/BuildSource.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/BuildSource.md b/docs/BuildSource.md index fe61262c400..eb15e292bfd 100644 --- a/docs/BuildSource.md +++ b/docs/BuildSource.md @@ -26,6 +26,9 @@ git checkout 2.5.0 cd build && make # To install make install +# To run the test suite +make installcheck +make install ``` Note, if you have multiple versions of PostgreSQL installed you can specify the path to `pg_config` @@ -70,3 +73,5 @@ cmake --build ./build --config Release --target install # Alternatively, build in Visual Studio via its built-in support for # CMake or by opening the generated build/timescaledb.sln solution file. ``` +# To run the test suite +make installcheck From 5cafa247564cf7448b22976dcdfffb38d63005ac Mon Sep 17 00:00:00 2001 From: "sweep-ai[bot]" <128439645+sweep-ai[bot]@users.noreply.github.com> Date: Thu, 1 Feb 2024 15:17:00 +0000 Subject: [PATCH 2/4] feat: Updated docs/BuildSource.md --- docs/BuildSource.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/BuildSource.md b/docs/BuildSource.md index eb15e292bfd..be025eb4d50 100644 --- a/docs/BuildSource.md +++ b/docs/BuildSource.md @@ -26,6 +26,7 @@ git checkout 2.5.0 cd build && make # To install make install +make installcheck # To run the test suite make installcheck make install From 7f233e426e253fc01c560883664223c7464129f6 Mon Sep 17 00:00:00 2001 From: "sweep-ai[bot]" <128439645+sweep-ai[bot]@users.noreply.github.com> Date: Thu, 1 Feb 2024 15:23:52 +0000 Subject: [PATCH 3/4] feat: Updated CONTRIBUTING.md --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c5f06665492..55134372eb6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -46,7 +46,7 @@ cd timescaledb * Hack away. Add tests for non-trivial changes. - * Run the [test suite](#testing) and make sure everything passes. + * Run the [test suite](#testing) and make sure everything passes **before you open a pull request**. * When committing, be sure to write good commit messages according to [these seven rules](https://chris.beams.io/posts/git-commit/#seven-rules). Doing @@ -99,7 +99,7 @@ cd timescaledb request, either mention them (preferably by GitHub name) in the PR's body or [assign them as a reviewer](https://help.github.com/articles/assigning-issues-and-pull-requests-to-other-github-users/). - * If you get a test failure in the CI, check them under [Github Actions](https://github.com/timescale/timescaledb/actions) + * If you get a test failure in the CI, check them under [Github Actions](https://github.com/timescale/timescaledb/actions). * Address feedback by amending your commit(s). If your change contains multiple commits, address each piece of feedback by amending that From 8736aa40e0052654e4698e30ec9049df69069e44 Mon Sep 17 00:00:00 2001 From: "sweep-ai[bot]" <128439645+sweep-ai[bot]@users.noreply.github.com> Date: Thu, 1 Feb 2024 15:24:27 +0000 Subject: [PATCH 4/4] feat: Updated CONTRIBUTING.md --- CONTRIBUTING.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 55134372eb6..a76f5338302 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -118,8 +118,7 @@ Please check that the full test suite (including your test additions or changes) passes successfully on your local machine **before you open a pull request**. -If you are running locally: -```bash +If you are running locally, execute the following commands to run the test suite: # Use Debug build mode for full battery of tests # Build the project in Debug mode @@ -130,7 +129,6 @@ cd .. ./bootstrap -DCMAKE_BUILD_TYPE=Debug cd build && make make installcheck -``` All submitted pull requests are also automatically run against our test suite via [Github Actions](https://github.com/timescale/timescaledb/actions)