Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should add a json checker to CI #24

Open
megies opened this issue Jan 23, 2018 · 1 comment
Open

Should add a json checker to CI #24

megies opened this issue Jan 23, 2018 · 1 comment

Comments

@megies
Copy link
Member

megies commented Jan 23, 2018

Would be good if CI could check for valid json (or even validating against a Jupyter notebook schema), for plain text changes to notebooks like in #23. Currently CI will be green even if there are .ipynb files that are no valid json.
@krischer
Copy link
Collaborator

Currenty there is no CI 🙈

There is a very rudimentary test routine in the root directory but it takes too long to execute to run in CI so I do agree that some basic linters would help a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krischer @megies