Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to turn this into a reusable plugin with semantic-release (core)? #294

Open
manuschillerdev opened this issue May 22, 2023 · 2 comments

Comments

@manuschillerdev
Copy link

New feature motivation

In my understanding, semantic-release-plus always needs to catch up with semantic-release when the upstream version changes. A reusable plugin for filtering commits by path in monorepos would probably be a very robust solution for a common problem. Would that be feasible?

New feature description

The possibility to filter commits by path is one of the core features of semantic-release-plus. If it were possible to extract the functionality this would be a super cool feature for the semantic-release ecosystem.

New feature implementation

Extract the functionality to filter relevant commits by path into a reusable plugin with semantic-release.
I am not sure if this is possible at all or what would need to be done implementation-wise.

@JoA-MoS
Copy link
Collaborator

JoA-MoS commented Mar 15, 2024

I agree, and it's been almost a year since you wrote this, Initially I tried very hard to get the upstream semantic-release to incorporate my changes but alas they were not interested in supporting a monorepo, and at the time the structure of the code with plugins did not provide a way to filter commits in a plugin. There are really only 2 parts that would need to be extracted and integrated into the core of semantic-release

  1. The filter mechanism
  2. The generating and retrieving git notes needs to be specific per release

The filter Mechanism is in this repo but I think 2 is only in my alpha branch which is located at semantic-release-plus/semantic-release-plus

My current job has started using semantic-release-plus so I will start making updates. It might be worth the effort to see if the upstream mentality has changed but previously they were not interested in the monorepo support.

@kf6kjg
Copy link

kf6kjg commented Jun 28, 2024

Trying to restart the discussion: semantic-release#1688 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants