fix: Update useStyledComponentsTarget to support case where head tag is removed. #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chat-ai-widget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +171 B (+0.03%) Total Size: 618 kB
ℹ️ View Unchanged
|
bang9
reviewed
Jan 23, 2025
| console.warn('[useStyledComponentsTarget]: Styled Components styles re-injected, switching to <body>'); | ||
| setTarget(document.body); | ||
| } else if (node instanceof HTMLElement && node.id === StyledId) { | ||
| moveStyleToBody(node); |
There was a problem hiding this comment.
nit: 요거 added 케이스는 제거가 되어도 될거같아요
There was a problem hiding this comment.
오 넵 헤드에 추가됐을 때 바디로 옮기는 로직이었네요. 있으면 안될 로직이네요. 완료했습니다.
bang9
reviewed
Jan 23, 2025
| const moveStyleToBody = (styleElement: HTMLElement) => { | ||
| if (styleElement && styleElement.parentElement !== document.body) { | ||
| console.warn(`[useStyledComponentsTarget]: Moving style element ${StyledId} to <body>.`); | ||
| document.body.appendChild(styleElement); |
There was a problem hiding this comment.
요거는 제거된 케이스에서만, body 대신 head 위치에 다시 추가하면 좋을 것 같습니다!
There was a problem hiding this comment.
제거된 케이스가 Head 에서 제거된 케이스로 이해했는데 그렇다면 head 에 추가할 수 없지 않을까요? 그래서 body 에 추가하도록 구현했어요.
|
@bang9 changelog 는 1.9.4 에 나간 그데로 적어놓긴 했는데, 다른 좋은 아이디어 있으실까요? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ticket: AA-772
Additional Notes
Checklist
Before requesting a code review, please check the following: