[CPLAT-4487] use custom header for tracing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bellatoris
force-pushed
the
doogie/CPLAT-4487
branch
3 times, most recently
from
fe88bd0 to
b350366
Compare
bellatoris
changed the base branch from
release/v1.30-sendbird-custom
to
release/v1.30.7-sendbird-custom
bellatoris
changed the base branch from
release/v1.30.7-sendbird-custom
to
main
bellatoris
changed the base branch from
main
to
release/v1.30.7-sendbird-custom
bellatoris
force-pushed
the
doogie/CPLAT-4487
branch
from
b350366 to
39e3b11
Compare
bellatoris
force-pushed
the
doogie/CPLAT-4487
branch
from
39e3b11 to
6d7b6ab
Compare
dlunch
reviewed
Nov 4, 2024
| @@ -15,8 +15,8 @@ namespace OpenTelemetry { | |||
|
|
|||
| class OpenTelemetryConstantValues { | |||
| public: | |||
| const Tracing::TraceContextHandler TRACE_PARENT{"traceparent"}; | |||
There was a problem hiding this comment.
It would be better to extract header name this into configuration, we can upstream it if we do
There was a problem hiding this comment.
Ok let me create a ticker for that.
dlunch
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use custom header for tracing